[haiku-bugs] Re: [Haiku] #7182: Fixing Menu keyboard navigation
- From: "stippi" <trac@xxxxxxxxxxxx>
- Date: Fri, 03 Jun 2011 14:16:01 -0000
#7182: Fixing Menu keyboard navigation
----------------------------------+----------------------------
Reporter: Pete | Owner: leavengood
Type: bug | Status: in-progress
Priority: normal | Milestone: R1
Component: Kits/Interface Kit | Version: R1/Development
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------+----------------------------
Comment (by stippi):
Since I am not on the ticket list anymore, I didn't see this before,
sorry. I looked over the patch. While I can't confirm every detail to be
correct, the changes do make sense to me. Of course the tracking code has
not become less complex, but leaving keyboard navigation broken is much
worse. The patch contains some coding style violations:
* The "else" goes on the same line as the closing parenthesis of the "if"
block (several occurances).
* Comments should go on their own line, preferably before the line of
code they refer to (several occurances).
* Never put the "if" or "else" statement on the same line as the clause
(one occurance).
One minor coding style violations:
* Check for pointers using "if (pointer == NULL)" and "if (pointer !=
NULL)" instead of "if (!pointer)" and "if (pointer)". Makes for more
readable code (sevaral occurances).
Thanks for the patch! Pete, are you going to fix the coding style issues?
I can do it, but I have no time right now, perhaps Ryan takes care of it.
In any case, the motivation is always much higher to apply and commit
patches when only testing has to be done and no cleanup on top.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7182#comment:7>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
