[haiku-bugs] Re: [Haiku] #7052: Deskbar Style Changes and Refactoring
- From: "jscipione" <trac@xxxxxxxxxxxx>
- Date: Tue, 01 Feb 2011 17:55:31 -0000
#7052: Deskbar Style Changes and Refactoring
-----------------------------------+---------------------------------
Reporter: jscipione | Owner: tqh
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/Deskbar | Version: R1/Development
Resolution: | Keywords: style refactoring
Blocked By: | Has a Patch: 1
Platform: All | Blocking:
-----------------------------------+---------------------------------
Comment (by jscipione):
> The patches is beginning to be large, so further changes should probably
be divided in to
> several patches. This way one patch at a time can be reviewed and
applied easily.
Yes it is large, there are a lot of style problems :) The only style
problems I see that are controversial are (line numbers from Deskbar Style
Changes and Refactoring 4.diff)
{{{
StatusView.cpp line 1044
Switcher.cpp line 1470
Switcher.cpp line 2066
}}}
Those comments maybe should be indented. Perhaps I got a little bit too
zealous with the unindenting. Perhaps some style expert can comment here.
--
Ticket URL: <http://dev.haiku-os.org/ticket/7052#comment:10>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
