[haiku-bugs] Re: [Haiku] #6750: chmod is broken for non-superuser

  • From: "axeld" <trac@xxxxxxxxxxxx>
  • Date: Fri, 05 Nov 2010 19:22:22 -0000

#6750: chmod is broken for non-superuser
-------------------------------+---------------------------------
  Reporter:  grahamh           |        Owner:  axeld
      Type:  bug               |       Status:  new
  Priority:  normal            |    Milestone:  R1
 Component:  File Systems/BFS  |      Version:  R1/Development
Resolution:                    |     Keywords:  chmod, write_stat
Blocked By:                    |  Has a Patch:  1
  Platform:  All               |     Blocking:
-------------------------------+---------------------------------

Comment (by axeld):

 This is not really what I meant with regards to the CheckPermissions()
 usage; since you aren't using it as I originally suggested, it doesn't
 seem to make any sense to use it at all for this; "{{{isOwnerOrRoot = uid
 == 0 || uid == node->UID()}}}" is at least way clearer.

 I would just remove the statMask from CheckPermissions() again, and make
 this pretty much a copy of how Ingo solved it, then. If you're still
 motivated, go ahead, otherwise I could do the changes to your patch as
 well :-)

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6750#comment:12>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: