[haiku-bugs] Re: [Haiku] #6721: Mail's reply preamble menu without "\n"

  • From: "pulkomandy" <trac@xxxxxxxxxxxx>
  • Date: Thu, 31 Mar 2011 09:08:42 -0000

#6721: Mail's reply preamble menu without "\n"
---------------------------------+----------------------------
   Reporter:  humdinger          |      Owner:  bga
       Type:  bug                |     Status:  new
   Priority:  normal             |  Milestone:  R1
  Component:  Applications/Mail  |    Version:  R1/Development
 Resolution:                     |   Keywords:
 Blocked By:                     |   Blocking:  7415
Has a Patch:  0                  |   Platform:  All
---------------------------------+----------------------------

Comment (by pulkomandy):

 Right, there is a bug in the first one :
 {{{
 stringToEscape.ReplaceAll("\\","\\\\");
 stringToEscape.ReplaceAll("\n","\\n");
 }}}

 The first line will do something like this : "\\n" > "\\\\n"
 and the second one afterwards : "\\\\n" > "\\\\\n"

 Definitely not what we want...

 Not sure how to fix it, maybe it will get as complex as the first one.

 The problem is as follow :
  * The key for each string is computed at runtime, so it's done from the
 string after compilation, where \n has been replaced by a real newline and
 so on
  * So, linkcatkeys must compute the key from the escaped string.
  * On the other hand, the catkey files must not be unescaped, because
 newlines and tabs are part of the file syntax here.

 parseQuotedChars works fine, as far as I can tell. It was tested a lot
 more.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6721#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: