[haiku-bugs] Re: [Haiku] #6487: [intel] overlapping partitions cannot be detected

  • From: "korli" <trac@xxxxxxxxxxxx>
  • Date: Wed, 25 Aug 2010 12:02:15 -0000

#6487: [intel] overlapping partitions cannot be detected
----------------------------+-----------------------------------------------
  Reporter:  rainbow-demon  |         Owner:  marcusoverhagen   
      Type:  bug            |        Status:  new               
  Priority:  normal         |     Milestone:  R1                
 Component:  Drivers/Disk   |       Version:  R1/Development    
Resolution:                 |      Keywords:  intel, overlapping
Blocked By:                 |   Has a Patch:  0                 
  Platform:  All            |      Blocking:                    
----------------------------+-----------------------------------------------

Comment (by korli):

 Replying to [comment:3 stippi]:
 > I remember seeing some code which does a plausibility test and refuses
 to accept the partition layout in Haiku, for this above case exactly. I
 don't see how Haiku could properly check this case, since partition layout
 scanning happens independent of contained file systems, so the partition
 scanning would not know that the file system contained in one of the
 overlapping partitions has an internal size that removes the overlap. As
 soon as you initialize this partition with another file system, you'd have
 a problem. Invalid partition maps are just bad. What should happen if you
 have a partition that completely lies within another partition?

 It happens [http://dev.haiku-os.org/browser/haiku/trunk/src/add-
 ons/kernel/partitioning_systems/intel/PartitionMap.cpp#L833 here].

 The case of rainbow-demon seems to be a corner case. I would suggest to
 check if the overlap is exactly one sector and then decrease the size of
 the partition object.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6487#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: