[haiku-bugs] Re: [Haiku] #6487: [intel] overlapping partitions cannot be detected

  • From: "korli" <trac@xxxxxxxxxxxx>
  • Date: Wed, 13 Oct 2010 07:10:09 -0000

#6487: [intel] overlapping partitions cannot be detected
----------------------------+-----------------------------------------------
  Reporter:  rainbow-demon  |         Owner:  marcusoverhagen   
      Type:  bug            |        Status:  new               
  Priority:  normal         |     Milestone:  R1                
 Component:  Drivers/Disk   |       Version:  R1/Development    
Resolution:                 |      Keywords:  intel, overlapping
Blocked By:                 |   Has a Patch:  1                 
  Platform:  All            |      Blocking:                    
----------------------------+-----------------------------------------------

Comment (by korli):

 Replying to [comment:10 bebop]:
 > Hey guys, just wanted to add a patch that allows for partitions to
 overlap. This implements the behavior that axel describes, as I understood
 him.

 Nice! Though you should check (i > 0) before accessing the array. Please
 also check the coding style: there spaces between i, minus and 1.
 {{{
 const Partition* previousPartition = byOffset[i - 1];
 }}}

 The minus operator goes on the next line
 {{{
 off_t previousSize = previousPartition->Size()
 - (nextOffset - partition->Offset());
 }}}

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/6487#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: