[haiku-bugs] Re: [Haiku] #5940: Header file for the USB video driver
- From: "mmlr" <trac@xxxxxxxxxxxx>
- Date: Sat, 08 May 2010 17:32:26 -0000
#5940: Header file for the USB video driver
-------------------------------+--------------------------------------------
Reporter: Karvjorm | Owner: mmlr
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Drivers/USB | Version: R1/Development
Keywords: USB video drivers | Blockedby:
Platform: All | Blocking:
-------------------------------+--------------------------------------------
Comment(by mmlr):
Replying to [comment:2 Karvjorm]:
> I noticed that all those header files (USB_audio.h, USB_hid.h,
USB_midi.h) use anonymous structs so I have used the same model.
Well no problem then. Maybe our gcc2 can handle them by now or I just
remember wrong, but I thought there were issues with anonymous unions at
least.
> Also, in USB_midi.h there are "uint8 cin: 4;" "uint8 cn: 4;" bitfield
definitions? At least this is better than "unsigned" only? This would then
be an endianness bug? Can you show where BITFIELD macros are used in Haiku
code?
Yes, at least use uint32 for example. The bitfield macros take the
endianness into account by switching the delaration order depending on the
target platform, see
source:/haiku/trunk/headers/private/drivers/lendian_bitfield.h for the
definitions and source:/haiku/trunk/src/add-
ons/kernel/bus_managers/ide/ide_device_infoblock.h for a usage example.
That file should probably be made public anyway.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5940#comment:3>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
