[haiku-bugs] Re: [Haiku] #5846: Playing avi video broken

  • From: "stippi" <trac@xxxxxxxxxxxx>
  • Date: Sat, 16 Oct 2010 21:51:50 -0000

#5846: Playing avi video broken
-----------------------------------+----------------------------------------
  Reporter:  X512                  |         Owner:  dlmcpaul 
      Type:  bug                   |        Status:  assigned 
  Priority:  normal                |     Milestone:  R1       
 Component:  Audio & Video/Codecs  |       Version:  R1/alpha2
Resolution:                        |      Keywords:           
Blocked By:                        |   Has a Patch:  0        
  Platform:  All                   |      Blocking:           
-----------------------------------+----------------------------------------

Comment (by stippi):

 I started looking into it and got caught up cleaning up the code versus
 looking at the actual problem. Of course cleaning it up I got a much
 better overview of what's actually there. I started removing all sorts of
 stuff which isn't actually implemented and just distracts from the bigger
 picture. Don't know if I committed that all, I believe not. A lot of stuff
 actually falls back to the C implementation and doesn't use SIMD at all.
 Then some stuff wrongly uses the NULL conversion which just does a
 memcpy(), while it should better do something. Some conversions are
 incorrectly implemented with a TODO in the code. I thought a good
 solution, since your code is so much faster when it works correctly, is to
 make sure no wrong conversions are used and for everything we don't
 support natively, use the swscale() codepath. For example also for the
 unaligned buffers, of which some are caught later in the code, i.e. *all*
 the checks need to be moved higher up in the code.

 Unless I missed something, what you wrote in the comment above can't
 really be the reason for the problem, since the swscale() code paths also
 use fContext.pix_fmt, so it should not work then either. Those are my
 findings so far, I won't be looking into this until Monday at least.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5846#comment:19>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: