[haiku-bugs] Re: [Haiku] #5636: [PATCH] Move resolv.conf updating from DHCP Client to net_server
- From: "axeld" <trac@xxxxxxxxxxxx>
- Date: Wed, 07 Apr 2010 08:39:03 -0000
#5636: [PATCH] Move resolv.conf updating from DHCP Client to net_server
--------------------------------+-------------------------------------------
Reporter: vegardw | Owner: axeld
Type: enhancement | Status: new
Priority: normal | Milestone: R1
Component: Servers/net_server | Version: R1/Development
Keywords: resolv.conf DHCP | Blockedby:
Platform: All | Blocking:
--------------------------------+-------------------------------------------
Comment(by axeld):
Looks good, thanks! I think I would make the third argument of
_ParseOptions() a reference, though, so that you don't have to check for
its validity - and if one want to choose between different offers, you
will have to take its data into account, anyway.
[[BR]]
There are a few style issues, though, like '{' on the next line, missing
space between "for" and '(', extra spaces after '(', etc. Also, I think I
would rename fResolverConfig to fResolverConfiguration in order to make it
fit better to the existing fConfiguration.
--
Ticket URL: <http://dev.haiku-os.org/ticket/5636#comment:2>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
