[haiku-bugs] Re: [Haiku] #5017: [Patch] Virtualmemory preflet localization

#5017: [Patch] Virtualmemory preflet localization
---------------------------------------+------------------------------------
 Reporter:  mt                         |       Owner:  axeld         
     Type:  enhancement                |      Status:  new           
 Priority:  normal                     |   Milestone:  R1            
Component:  Preferences/VirtualMemory  |     Version:  R1/Development
 Keywords:                             |   Blockedby:                
 Platform:  All                        |    Blocking:                
---------------------------------------+------------------------------------

Comment(by stippi):

 Hi mt! The patch looks good except for the following issues:

 In the function byte_size(), you should not modify the static const char
 units line at all. You already added the TR marco to where the static
 strings are used. And this asks the question whether it should be the
 TR_MARK macro there instead.

 I don't have much experience with translation requirements, but I believe
 I have heard that it's better to leave string compositing to the
 translation process. So instead of

 {{{
 BString string(TR("Physical Memory: "));
 string << memory << TR(label);
 }}}

 you would use some form of compositing method which BLocal perhaps
 provides. ("Phsyical Memory: %1%2", bytes, label). Some translation could
 then change the order of strings in the composition, if you know what I
 mean.

 Thanks a lot for the patch! You could leave the second problem to someone
 else if you want, or I can apply your patch fixing the first issue I
 pointed out. Just tell me.

-- 
Ticket URL: <http://dev.haiku-os.org/ticket/5017#comment:1>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: