[haiku-bugs] Re: [Haiku] #4868: Appearance - "negative colors" not respected - hardcoded black text?
- From: "jscipione" <trac@xxxxxxxxxxxx>
- Date: Mon, 11 Jun 2012 16:51:36 -0000
#4868: Appearance - "negative colors" not respected - hardcoded black text?
--------------------------------------+-----------------------
Reporter: m0ns00n | Owner: jscipione
Type: bug | Status: assigned
Priority: normal | Milestone: R1
Component: Preferences/Appearance | Version: R1/alpha1
Resolution: | Keywords:
Blocked By: 5293 | Blocking:
Has a Patch: 0 | Platform: x86
--------------------------------------+-----------------------
Comment (by jscipione):
Nice you to see you back Ryan. In ControlLook.cpp in the DrawLabel()
method (line 1772 at the time of this writing) Stippi has written the
prototype of how to draw a label black on a light background or white on a
dark background. I assume that there must be code in Tracker to do this as
well since it seems to work for text on the Desktop. To fix this bug we
need to find instances of B_CONTROL_TEXT_COLOR and the other text color
constants and replace them with a function call (perhaps defined in
Interface Defs) that calculates the text color (black or white) from the
background color as the code in ControlLook does.
With that done we can then deprecate those constants. Although I have some
pending Appearance work to commit, it focuses on fixing instances where
the color constants should be used to make more constants function, not
deprecating constants. So feel free to do the work on this ticket if you'd
like. I won't get back to this for a while now as I'm currently focused
elsewhere.
--
Ticket URL: <http://dev.haiku-os.org/ticket/4868#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
