[haiku-bugs] Re: [Haiku] #4562: MIDI endpoint icons should support vector icon format too
- From: "Pete" <trac@xxxxxxxxxxxx>
- Date: Mon, 30 Nov 2009 22:18:07 -0000
#4562: MIDI endpoint icons should support vector icon format too
----------------------------+-----------------------------------------------
Reporter: phoudoin | Owner: phoudoin
Type: enhancement | Status: closed
Priority: normal | Milestone: R1
Component: Kits/Midi Kit | Version:
Resolution: fixed | Keywords:
Blockedby: | Platform: All
Blocking: |
----------------------------+-----------------------------------------------
Comment(by Pete):
Replying to [comment:11 phoudoin]:
>
> Nice spotted, and stupid error from my side.
> This should be fixed in r34358, while a vector icon aware PatchBay
patched after your changes posted in haiku-development ML is available
since r34357.
Considering both of us made exactly the same error... (:-/)
Anyway, thanks for fixing, and adding the vector-aware PatchBay.
However, some observations:
1) in 34358, why didn't you just make the resources a global? I suppose
copying just the icon data to a new array saves a few hundred bytes, but
seems unnecessarily complicated.
2) I (finally) noticed that the row/column display bug I'd fixed in my
copy of PatchView.cpp is fixed independently in the code you uploaded.
Did you fix it, or is it somehow a later archive than the (I thought
final) copy I had? The rest of the source is identical.
3) When you added my patch to EndpointInfo.cpp, you left in the printfs
that I had added for debugging. (They were actually DPRINTFs, but I
edited for the mailing list.) Also, if you want to leave the "#ifdef _
_HAIKU_ _" around it, you should do the same to "#include <IconUtils.h>".
Or -- as I suspect it will quickly become BeOS incompatible -- just omit
the conditional.
4) I don't believe the added 'libicon.a' in the jamfile is needed: I think
it's included in libbe. When I was compiling PatchBay in userland, I
simply linked IconUtils.h into the /boot/develop/headers hierarchy, and
everything built and ran.
In any case, I'm still working on PatchBay. I want to replace the
horrible [to my eye] 'Unknown Device' icon with a vector one, and get rid
of UnknownDeviceIcons.h by adding an rdef. In the process it should also
get an App Icon -- maybe a couple of crossed MIDI-cables? Still thinking
on that...
--
Ticket URL: <http://dev.haiku-os.org/ticket/4562#comment:12>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
