[haiku-bugs] Re: [Haiku] #1503: MediaPlayer doesn't remember previous volume setting

  • From: "korli" <trac@xxxxxxxxxxxx>
  • Date: Mon, 22 Sep 2014 10:54:43 -0000

#1503: MediaPlayer doesn't remember previous volume setting
----------------------------------------+----------------------------
   Reporter:  scottmc                   |      Owner:  waddlesplash
       Type:  enhancement               |     Status:  assigned
   Priority:  normal                    |  Milestone:  R1
  Component:  Applications/MediaPlayer  |    Version:  R1/Development
 Resolution:                            |   Keywords:
 Blocked By:                            |   Blocking:
Has a Patch:  1                         |   Platform:  All
----------------------------------------+----------------------------

Comment (by korli):

 Thanks for the patch!
 Here are some coding issues:
 * two blank lines between methods.
 * space before and after operators (/ % = ...), line 704, 714, 716 in
 Controller.cpp
 * line 692 in Controller.cpp: two tabs instead of one.
 * line 717 in Controller.cpp: 80 characters length.
 * FilePlaylistItem.cpp: multiline blocks require braces.

--
Ticket URL: <https://dev.haiku-os.org/ticket/1503#comment:21>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: