[haiku-bugs] Re: [Haiku] #1503: MediaPlayer doesn't remember previous volume setting
- From: "pulkomandy" <trac@xxxxxxxxxxxx>
- Date: Fri, 22 Aug 2014 06:38:58 -0000
#1503: MediaPlayer doesn't remember previous volume setting
----------------------------------------+---------------------------
Reporter: scottmc | Owner: stippi
Type: enhancement | Status: assigned
Priority: normal | Milestone: R1
Component: Applications/MediaPlayer | Version: R1/pre-alpha1
Resolution: | Keywords:
Blocked By: | Blocking:
Has a Patch: 1 | Platform: All
----------------------------------------+---------------------------
Comment (by pulkomandy):
Style violations:
* 2 blank lines between methods
* Missing space between if and (
* Missing space after =
Functionality:
* The BAlert for resuming isn't locale-safe. Use BString.SetToFormat()
and B_TRANSLATE().
* I don't understand why the 50* and /50 on volume. Wouldn't it be
simpler if the volume was stored as a float between 0 and 1 everywhere?
--
Ticket URL: <https://dev.haiku-os.org/ticket/1503#comment:17>
Haiku <https://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
