[haiku-bugs] Re: [Haiku] #1006: inconsistent behavior of Revert button in Backgrounds preflet (easy)
- From: "tangobravo" <trac@xxxxxxxxxxxx>
- Date: Tue, 18 May 2010 20:17:22 -0000
#1006: inconsistent behavior of Revert button in Backgrounds preflet (easy)
-------------------------------------+--------------------------------------
Reporter: wkornewald | Owner:
Type: bug | Status: new
Priority: low | Milestone: R1
Component: Preferences/Backgrounds | Version: R1/pre-alpha1
Keywords: | Platform: All
Blockedby: | Patch: 0
Blocking: |
-------------------------------------+--------------------------------------
Comment(by tangobravo):
Replying to [comment:38 ekam]:
> tangobravo: That's the problem when there's lots of ideas but nobody to
decide what to do.
There will be a decision, stippi is likely to be the one to make the call
in the end. I don't see a problem with suggesting alternatives though.
It seems you both prefer not to have settings applied live, which means
keeping the apply button, and therefore there's no need to change the menu
field.
As the guy doing the implementation, you'd probably be the one to decide
the exact scheme used. Following Stephan's suggestion outlined above seems
a good plan to me:
"IMHO, what should happen is that the code separates settings per
workspace. For this I would introduce three sets of values: intial,
changed and current. When the panel is opened, and when you switch to a
workspace, one new set of values for this workspace is instantiated. The
"initial" values are easy to assign, and it happens only once. The
"current" set of values reflect the workspace as the user can see it on
the screen. The "changed" values are adopted from the changes the user
makes in UI. The Revert button is then enabled when either the current OR
the changed values are unequal to the initial values. The Apply button is
enabled whenever the current and changed values are not the same."
All that needs further specifying is the revert behaviour. I would
suggest:
Revert will set the current workspace back to it's initial state, or all
workspaces if "All Workspaces" is selected in the menu field.
I've left out Stippi's Undo suggestion - I don't think it would be useful
often, and will add confusion for the user as to the difference between
undo and revert. Often with these things it's hard to know how it will
feel until it's actually been implemented though.
--
Ticket URL: <http://dev.haiku-os.org/ticket/1006#comment:39>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.
Other related posts:
