[haiku-appserver] Re: new drawing bug
- From: Adi Oanca <adioanca@xxxxxxxxxxxxxx>
- To: haiku-appserver@xxxxxxxxxxxxx
- Date: Wed, 09 Nov 2005 15:29:35 +0200
Stefano Ceccherini wrote:
one of the recent commits has obviously broken line drawing.
Have a look at the picture:
http://www.pinc-software.de/images/new_app_server_bug.png
I _think_ I've found the problem (by looking at recent changes, haven't
tried or anything):
http://svn.berlios.de/viewcvs/haiku/haiku/trunk/src/servers/app/ServerWindow.cpp?rev=14778&r1=14773&r2=14778&diff_format=l
Check the AS_STROKE_LINE case:
The "Convert***" methods we had before didn't modift the passed parameters, the
new one do, so we are setting the new pen location in Screen coordinates instead of View
coordinates.
Yup! :-) Looks like our problem.
Good catch Stefano! ;-)
This might happen in other places as well.
Let's hope not. :-)
Bye,
Adi.
- References:
- [haiku-appserver] Re: new drawing bug
- From: Stefano Ceccherini
Other related posts:
- » [haiku-appserver] new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
- » [haiku-appserver] Re: new drawing bug
one of the recent commits has obviously broken line drawing. Have a look at the picture: http://www.pinc-software.de/images/new_app_server_bug.png
I _think_ I've found the problem (by looking at recent changes, haven't tried or anything):
http://svn.berlios.de/viewcvs/haiku/haiku/trunk/src/servers/app/ServerWindow.cpp?rev=14778&r1=14773&r2=14778&diff_format=l
Check the AS_STROKE_LINE case: The "Convert***" methods we had before didn't modift the passed parameters, the new one do, so we are setting the new pen location in Screen coordinates instead of View coordinates.
Yup! :-) Looks like our problem. Good catch Stefano! ;-)
Let's hope not. :-)
Bye, Adi.
- [haiku-appserver] Re: new drawing bug
- From: Stefano Ceccherini