[gpodder-devel] [PATCH] Always use notifications to mention completed sync

This is currently the behaviour of the downloads and it makes sense for
the device sync to do this as well. Otherwise you can have problems with
a model dialog popping up on a random workspace waiting for user action
---
 src/gpodder/gui.py      |    2 --
 src/gpodder/trayicon.py |    5 ++---
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/gpodder/gui.py b/src/gpodder/gui.py
index 65accbe..8e5a9fa 100644
--- a/src/gpodder/gui.py
+++ b/src/gpodder/gui.py
@@ -4135,8 +4135,6 @@ class gPodderSync(BuilderWidget):
 
     def on_done(self):
         util.idle_add(self.gPodderSync.destroy)
-        if not self.gPodder.minimized:
-            util.idle_add(self.notification, _('Your device has been updated 
by gPodder.'), _('Operation finished'))
 
     def on_gPodderSync_destroy(self, widget, *args):
         self.device.unregister('progress', self.on_progress)
diff --git a/src/gpodder/trayicon.py b/src/gpodder/trayicon.py
index 1cf755e..369d736 100644
--- a/src/gpodder/trayicon.py
+++ b/src/gpodder/trayicon.py
@@ -350,9 +350,8 @@ class GPodderStatusIcon(gtk.StatusIcon):
         log("tooltip: %s", tooltip, sender=self) 
 
     def __on_synchronisation_done(self):
-        if self.__gpodder.minimized:
-            # this might propably never appends so long gPodder synchronizes 
in a modal windows
-            self.send_notification(_('Your device has been updated by 
gPodder.'), _('Operation finished'))
+        # this might propably never appends so long gPodder synchronizes in a 
modal windows
+        self.send_notification(_('Your device has been updated by gPodder.'), 
_('Operation finished'))
         self.set_status()
         
     def draw_progress_bar(self, ratio):
-- 
1.6.3.3



Other related posts:

  • » [gpodder-devel] [PATCH] Always use notifications to mention completed sync - Alex Bennee