[gmpi] Re: Plugin Factory Update

Angus F. Hewlett wrote:

Tim Hockin wrote:

Jeff,  I have changes to the C++ version too.  I'll incorporate these,
but I will comment in line here:


On Tue, Mar 01, 2005 at 11:49:36AM +1300, Jeff McClintock wrote:


2. Ron.
"when comparing values in an 'if', put the constant value on the left side, not the right."


I personally find this incredibly hard to read. If there is a strong
swell of support for this, then OK, but I *hate* it.


IMHO it's good. Does make the eye jump a bit at first, but I've gotten used to it.


Although I can see where Ron is coming from - "if there are three pumpkins in the larder then don't buy any more" is structurally better represented as;-

if (3 == larderContents(pumpkins))
   {
   !buy(pumpkins);
   }

but I've racked my brains and can't think of any case where I've seen this convention used before in my rather too many decades of cursing computers or, if it was there, my eye jumped so much I just missed it altogether. Please, for us old fossils sake, can we stick with if (variable == constant) ?

   Dave


--
These are my own views and may or may not be shared by my employer
/*********************************************************************/
/* Dave Malham   http://music.york.ac.uk/staff/research/dave_malham/ */
/* Department of Music    "http://www.york.ac.uk/depts/music/";       */
/* The University of York  Phone 01904 432448                        */
/* Heslington              Fax   01904 432450                        */
/* York YO10 5DD                                                     */
/* UK                   'Ambisonics - Component Imaging for Audio'   */
/*                    "http://www.york.ac.uk/inst/mustech/3d_audio/"; */
/*********************************************************************/

Other related posts: