[geekcrypt] Re: Macros Macros everywhere...
- From: PID0 <p1dz3r0@xxxxxxxxx>
- To: geekcrypt@xxxxxxxxxxxxx
- Date: Thu, 05 Jun 2014 21:32:44 +0100
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Some of this code is formatted in a way that looks like it was cobbled
together using an IDE that decided, on some days, to write in C, C#
and C++.
As it stands it's quite...thick to read through (variables called "v"
spanning several classes), auditing this for bugs is going to be...fun :\
Chris
On 05/06/2014 21:28, Bill Cox wrote:
> On Thu, Jun 5, 2014 at 4:06 PM, PID0 <p1dz3r0@xxxxxxxxx> wrote:
>
>> ...but not a single sensibly named variable to be found in 110k
>> lines of code. My personal favorite bit of coding lunacy I've
>> found so far is:
>>
>> #define PLATFORM_BYTE_ORDER BYTE_ORDER #define IS_LITTLE_ENDIAN
>> LITTLE_ENDIAN
>>
>> #if (PLATFORM_BYTE_ORDER == IS_LITTLE_ENDIAN) ...
>>
>
> This is going to take a lot of work to clean up. The GUI author
> seemed to think that he needed a different class for each use of a
> string. For example, in class Volume, he added class VolumePath
> with no functionality other than to convert from all the other
> string classes!
>
> I don't think we need to worry about cleaning up the code much
> until after the first release. After that, well we need to make a
> plan...
>
> Bill
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTkNPsAAoJELgbaWaCeTqDLtcH/0aA4E2SrdbZfvB2R0b09uHO
c32Zw97XNL1tpEb+qX35l8cZgNiLQiSQJpfih5HfVm5u3wl/1lR75//cQQlviPyH
7GZda2hysKWostrMmjJ+Yh/Aej+QTHQQ+tcEDg+11YRGoxKwKAL3UTu5gTvWys5n
uozJysOKJdMVjv8ZGR/EF3P+0i4M99Vvb/dsbrDIiT1a9aFJ5lge9Hfm/kNsu98a
oeUKiAcJDRXVw/7qI8nIc8lO1fns+pyWvtSCTqpE8hu0M5Qwa+VCYJBkY5nvgqHN
iHbQSqyIqiq2QFml2BXVyntn77NDPx9RhldnbypAfi9ad1kvj0hvEfpoqks3bvY=
=gD3S
-----END PGP SIGNATURE-----
Other related posts:
