[ewiki] Re: ewiki.php changes

On Fri, 2004-02-27 at 19:23, Mario Salzer wrote:
> Btw, should we leave $ewiki_data["content"] for reuse by yoursite? Often
> it is a very small amount of text, but could it be valueable to any other
> extension?

Lets leave it out for now pending a request.

> > 3.  Inside ewiki_script() as part of the workaround for slashes in $id
> > an $asid is hardcoded to "view" I suggest using the EWIKI_DEFUALT_ACTION
> > constant.
> 
> changed.
> 
> >
> > I also posted a bug and fix to BugReports.
> 
> For the "0" page name I have to say, this is an acceptable bug!
> IMHO we could end up applying fixes for this all over the code,
> just to work around PHP language design (in fact good one, this
> time), and that's just not worth it.
> 
> I would even go so far and promote this as feature! "A link
> of [0] always goes to the FrontPage."
> Hope that's acceptable for everyone else, as it really only
> is about the "0" page name. (Somewhere I even took a note
> about this, one year ago.)

Ok, I guess I can live with that, kinda strange though.  I ran my fix in
production with no ill effects fyi.


Other related posts: