[ewiki] Re: ewiki.php changes

> Jeff and I have made some changes to ewiki.php that I think we should
> consider merging in, but I expect will take some disscussion:
>
> 1.  Move $ewiki_t up above the init plugins loop so that these plugins,
> particularly ewiki_binary() can use ewiki_t()

Personally, I would favour to move the init loop down, but that's
more a source code editing issue ;)

>
> 2.  We moved $ewiki_data=&$data to the end of ewiki_page just before
> unset($ewiki_data["content"]).  This was done because we did not want
> the data to be available if the auth call was failed.  There was also a
> problem if the binary handler was called.  The problem with the binary
> was that the binary handler would not know about $ewiki_data and could
> not clean it up like ewiki_page does by unsetting the "content" field.

I've placed it there, so it still was there "if the auth call was failed"
(what is quite contradictory to what you want).

But really I don't know which approach was the better here. (For binary
content it's clear.)  Since you have more knowledge in _PROTECTED_MODE
and auth calls, it appears to be the right thing to do anyhow. ;)

Btw, should we leave $ewiki_data["content"] for reuse by yoursite? Often
it is a very small amount of text, but could it be valueable to any other
extension?


>
> 3.  Inside ewiki_script() as part of the workaround for slashes in $id
> an $asid is hardcoded to "view" I suggest using the EWIKI_DEFUALT_ACTION
> constant.

changed.

>
> I also posted a bug and fix to BugReports.

For the "0" page name I have to say, this is an acceptable bug!
IMHO we could end up applying fixes for this all over the code,
just to work around PHP language design (in fact good one, this
time), and that's just not worth it.

I would even go so far and promote this as feature! "A link
of [0] always goes to the FrontPage."
Hope that's acceptable for everyone else, as it really only
is about the "0" page name. (Somewhere I even took a note
about this, one year ago.)

mario

Other related posts: