[ewiki] Re: ewiki_eventually_initialize()

Hmm, I've had two problems with this plugin that this happens to address,
but this may not truly be necessary.

1.  If the current EWIKI_INDEX does not exist this plugin runs to 'fix' the
problem, but cannot.  Because this plugin forces the action to view
ewiki_page_view() is now running on an empty page.  This bypasses the normal
empty page check and behaves strangely.

2.  When ewiki_eventually_initialize() runs it can create new pages if you
have updated EWiki and grabbed new init_pages.  This may or may not be
acceptable.

How about making ewiki_eventually_initialize() run only in unprotected mode?

Andy

> > Adding:
> >   if (!ewiki_auth($id, $data, 'initialize', $ring=0, $request_auth=0)) {
> > in ewiki_eventually_initialize() inside the first if (line 2648 in CVS
> > 1.105) will add authentication and prevent accidental initialization.
> I'm
> > not sure quite how to remove the explicit ring, but perhaps it is ok for
> > this kind of admin call?
> 
> Do you really feel this is neccessary? I mean this plugin is just run
> once,
> and can safely be ignored afterwards, because it would never activate
> again
> until the FrontPage was deleted again (I guess even this wouldn't work
> anymore), and after all couldn't even overwrite any existing pages. I'd
> really say this _initialize() function is harmless enough to completely
> ignore the _PROTECTED_MODE here.
> 
> On the other hand I already thought about an external _initialization
> plugin
> contained inside ./init-pages (with an integrated setup wizard or so),
> because this function then was run just once, and everybody tweaking ewiki
> (not using the default ewiki tarball dirtree and example layouts) could
> probably manage to insert those initial pages herself. But I fear
> overcomplicating things with such a temporary initialization-wizard-plugin
> (and it would only free a few lines in the core script).

Other related posts: