[ewiki] Re: Merge Notes

Here is aview_subpages.php revised as discussed. 

Andy


> -----Original Message-----
> From: Andy Fundinger [mailto:andy@xxxxxxxxxxx]
> Sent: Thursday, December 11, 2003 10:09 AM
> To: 'ewiki@xxxxxxxxxxxxx'
> Subject: [ewiki] Re: Merge Notes
> 
> What about specifying that perm plugins can expect to receive either the
> full database entry or an empty variable in $data and must be ready to
> perform their own GET if they need to?  We already pass them empties many
> places and I know some of my GETs could be removed if we established that
> such a rule.  The more I thought about it on my way home last night the
> better I liked it.
> 
> Andy
> 
> 
> > -----Original Message-----
> > From: Mario Salzer [mailto:mario@xxxxxxxxxxxxx]
> > Sent: Wednesday, December 10, 2003 9:49 PM
> > To: ewiki@xxxxxxxxxxxxx
> > Subject: [ewiki] Re: Merge Notes
> >
> > Hi,
> >
> > > 1. In ewiki_page(), where did the finished variable go?
> > >    #-- ready
> > >    if ($finished) {
> > >       $o .= $handler_o;
> > >    }
> >
> > It should have of course read "if ($handler_o)" here; but it's fixed
> now.
> > Thank you for the note.
> >
> > > Also, if you want it I have some timing/debugging/logging code I can
> > submit.
> >
> > I already dreamed about a debug plugin ;-)  but currently I don't like
> to
> > have lots of if(EWIKI_DEBUG){...} around, even if it was sometimes
> > helpful.
> >
> >
> > > I disagree with your fix in aview_subpages.php, $result->get($_hiding)
> > > appears not to get enough information for the auth plugin to work on.
> > > Specifically, as I read the code, meta data is not retrieved.  If you
> > want
> > > ...
> >
> > Actually, the "$result->get()" should already retrieve the full database
> > entry, if a parameter is passed "$result->get(55.3)". But it appears
> that
> > there was a bug in the database result class (again odd variable names).
> > Using this ->get(1) syntax may be sometimes faster (buffering), than a
> > separate e_db(GET) call - but basically it's the same now.
> >
> >
> > mario
> >
> >
> >
> >
> > _________________________________________________
> > Scanned on 11 Dec 2003 02:49:28
> > Scanning by http://erado.com
> 
> 
> 
> _________________________________________________
> Scanned on 11 Dec 2003 15:14:20
> Scanning by http://erado.com

Other related posts: