[ewiki] Re: Bug in ewiki_control_links()

Eeek!  I have a plugin that uses the old method.  When will this be in the
CVS?

(For those on the list, the bug was that ewiki_auth was being called with
($uu, $uu, $action))

How about having ewiki_auth() return TRUE/'0'/FALSE on success or a message
on anything less than success?  I prefer 0 for all it's illogic because we
can just test '==0', but with a definate TRUE we could use '===' to be sure
of the return.

Andy

> -----Original Message-----
> From: Mario Salzer [mailto:mario@xxxxxxxxxxxxx]
> Sent: Monday, October 27, 2003 12:08 PM
> To: andy@xxxxxxxxxxx
> Subject: Bug in ewiki_control_links()
> 
> > if (EWIKI_PROTECTED_MODE
> >               && (   !ewiki_auth($id, $uu, $action)
> >                   || EWIKI_PROTECTED_MODE_HIDING && empty($ewiki_ring)
> 
> I'm usure why it was that way, but I now decided it could even negotiate
> on $data. Btw, I'll changed ewiki_auth() to return error messages now
> via a new global $ewiki_errmsg instead of the &$data, the drawback beeing
> that this new global isn't autocleared (at least better than garbaging
> the parent functions &$data).
> 
> mario

Other related posts: