Re: emelfm2 0.6.0: segfault on config update

On Sat, 09 May 2009 13:29:52 +0200
Christoph Wickert wrote:

> > > Three more things I'd like to mention, although they are minor:
> > >      1. "lib" is hardcoded in the Makefile "lib" (once in
> > >         $(PREFIX)/lib/$(TARGET)/$(LIBS)). Can this replaced to
> > > work also for lib64 be default, so one doesn't have to manually
> > > add PLUGINS_DIR?  
> > 
> > svn now has LIB_DIR ?= $(PREFIX)/lib  
> 
> I was talking about $(PREFIX)/lib vs. $(PREFIX)/lib64, but I'm not
> sure if there is an autoconf macro for that.

It is a trivial matter in Fedora to include the attached patch, and
modify the emelfm2.spec accordingly.

%ifarch x86_64
%patch0 -p0
%endif

plugins will now be installed in /usr/lib64 on x86_64 and in 
usr/lib on ix86.


> > >      3. In the desktop file you define the icon with
> > > "Icon=emelfm2", but you are not installing it anywhere in the
> > > icon search path. Ether install it to say /usr/share/pixmaps or
> > > use the full path in the desktop file.  
> > 
> > I can't specify an absolute path that suits everyone.   
> 
> Agreed, but...
> 
> > The package should install the icon somewhere  suitable for the
> > distro.  
> 
> AFAICT /usr/share/pixmaps/emelfm2 wont work on any distro,
> only /usr/share/pixmaps will. So IMO emelfm2_48.png should be
> symlinked to /usr/share/pixmaps/emelfm2.png

The preferred method in xdg Is to use only the 'name' as this allows
for the usage of different sized icons depending upon the WM/theme/etc
which is being employed by the user.

This can also be achieved by the packager in the Fedora emelfm2.spec
by additionally installing the icons to the preferred default icon
directory used by Fedora.

This is from my current mandriva emelfm2.spec which I am use for my
svn builds.

install -m 644 -D icons/emelfm2_48.png
%{buildroot}%{_iconsdir}/hicolor/48x48/apps/%{name}.png
install -m 644 -D icons/emelfm2_32.png
%{buildroot}%{_iconsdir}/hicolor/32x32/apps/%{name}.png
install -m 644 -D icons/emelfm2_24.png
%{buildroot}%{_iconsdir}/hicolor/24x24/apps/%{name}.png 


    Charles


-- 
The young lady had an unusual list,
Linked in part to a structural weakness.
She set no preconditions.
----------------------
Mandriva Linux release 2010.0 (Cooker) for x86_64$
On SuperSize....http://www.eslrahc.com
Registered Linux user #182463
2.6.29.1-tmb-server-3mdv AMD Athlon(tm) 64 X2 Dual Core Processor 6400+
----------------------

--- Makefile.config~    2009-05-09 15:38:45.000000000 -0400
+++ Makefile.config     2009-05-09 15:41:00.000000000 -0400
@@ -163,7 +163,7 @@
 #as well as 'make' usage, all in-code uses of these paths assumes they're 
localised
 PREFIX ?= /usr/local
 BIN_DIR ?= $(PREFIX)/bin
-LIB_DIR ?= $(PREFIX)/lib
+LIB_DIR ?= $(PREFIX)/lib64
 PLUGINS_DIR ?= $(LIB_DIR)/$(TARGET)/plugins
 #FIXME by default, apps should look for icons in $XDG_DATA_DIRS/icons
 # and in /usr/share/pixmaps (in that order).

Other related posts: