Re: emelfm2 0.6.0: segfault on config update

Am Samstag, den 09.05.2009, 16:06 +1000 schrieb tpgww@xxxxxxxxxxx:
> On Sat, 09 May 2009 05:17:31 +0200
> Christoph Wickert <christoph.wickert@xxxxxxxxxxxxxx> wrote:
> 
> > Three more things I'd like to mention, although they are minor:
> >      1. "lib" is hardcoded in the Makefile "lib" (once in
> >         $(PREFIX)/lib/$(TARGET)/$(LIBS)). Can this replaced to work also
> >         for lib64 be default, so one doesn't have to manually add
> >         PLUGINS_DIR?
> 
> svn now has LIB_DIR ?= $(PREFIX)/lib

I was talking about $(PREFIX)/lib vs. $(PREFIX)/lib64, but I'm not sure
if there is an autoconf macro for that.

> >      2. Similar to DEBUG the Makefile should have a STRIP=0 option to
> >         prevent stripping of binaries and libs. rpm takes care of this
> >         and if the binaries get stripped before, rpm is no longer able
> >         to create a valid emelfm2-debuginfo package.
> 
> svn now has STRIP ?= 1  For rpm with debug packages you probably want to 
> override it to 0

Excellent, thanks.

> >      3. In the desktop file you define the icon with "Icon=emelfm2", but
> >         you are not installing it anywhere in the icon search path.
> >         Ether install it to say /usr/share/pixmaps or use the full path
> >         in the desktop file.
> 
> I can't specify an absolute path that suits everyone. 

Agreed, but...

> The package should install the icon somewhere  suitable for the distro.

AFAICT /usr/share/pixmaps/emelfm2 wont work on any distro,
only /usr/share/pixmaps will. So IMO emelfm2_48.png should be symlinked
to /usr/share/pixmaps/emelfm2.png


> Regards
> Tom

Kind regards,
Christoph



-- 
Users can unsubscribe from the list by sending email to 
emelfm2-request@xxxxxxxxxxxxx with 'unsubscribe' in the subject field or by 
logging into the web interface.

Other related posts: