Re: emelfm2 0.6.0: segfault on config update

On Sat, 9 May 2009 10:50:19 +1000
<tpgww@xxxxxxxxxxx> wrote:

> On Sat, 09 May 2009 01:29:36 +0200
> Christoph Wickert <christoph.wickert@xxxxxxxxxxxxxx> wrote:
> 
> > emelfm2 itself works fine here and I can't confirm the problems that
> > Hans reported earlier today, but the update of the configuration does
> > not work. The dialog asking for a config upgrade pops up, but as soon as
> > I hit "Apply" or "Abort" e2p_upgrade.so causes a crash. For me
> > personally it's ok to remove my config and start with a fresh one, but
> > not for all the Fedora users, so I'm I cannot update to 0.6.0 before
> > this issue is fixed.
> 
> Thanks Christoph.
> 
> A function assumes that it's being run after the main-window is created, but 
> in the case of the config upgrade dialog, that's not so. A quick fix is to 
> comment line 538 in e2_main.c
> //    e2_utils_fake_event ();
> I expect this change doesn't harm anything else, but I'd like to evaluate 
> that further.
> 
> BTW, that dialog is supposed to run if the session-start config data is older 
> than v.0.5.0, or else sed(1) (to manipulate the config file) can't be found. 
> Is that working as expected?

Better solution:

Do not change e2_main.c

e2p_upgrade.c at lines 135/6 is:
//      gint choice = gtk_dialog_run (GTK_DIALOG (dialog));     //not a local 
loop as options not yet available
        gint choice = e2_dialog_run_simple (dialog, NULL);
Swap the commenting, i.e.
        gint choice = gtk_dialog_run (GTK_DIALOG (dialog));     //not a local 
loop as options not yet available
//      gint choice = e2_dialog_run_simple (dialog, NULL);
 
Regards
Tom


-- 
Users can unsubscribe from the list by sending email to 
emelfm2-request@xxxxxxxxxxxxx with 'unsubscribe' in the subject field or by 
logging into the web interface.

Other related posts: