Re: "WITH_THUMBS=1" broken with --as-needed in LDFLAGS?
- From: <tpgww@xxxxxxxxxxx>
- To: emelfm2@xxxxxxxxxxxxx
- Date: Thu, 1 Jan 2009 20:16:03 +1100
On Wed, 31 Dec 2008 15:31:57 -0000 (GMT)
"Sadako" <sadako@xxxxxxxxxxxxxxxxx> wrote:
> ... but maybe the "optional" plugins each need their own logic
> within the Makefile?
Sofar I 've managed to avoid a close look at the Makefile. Maybe it's finally
time to attend to it, to do the plugins construction properly. Here at least,
any "--as-needed" flag does nothing, and I've seen information to the effect
that it's not necessarily reliable, and not present for all supported OS's. So
we would be foolish to rely on it.
> Also, another (related) issue, portage complains about all the plugins
> installed under /usr/lib/emelfm2/plugins ignoring LDFLAGS.
> Adding "sed -e 's:$(lLIBS_CFLAGS):$(lLIBS_CFLAGS) $(lLDFLAGS):g' -i
> Makefile" to the ebuild seems to satisfy portage at least (and this had
> nothing to do with breaking e2p_thumbs.so).
We can clean this up more efficiently, I think. For example lLDFLAGS is just
LDFLAGS.
> There are a few other issues or suggestions I have, but I'm not a
> programmer so can't really help with them myself (as much as I'd like to),
> and I really don't wish to annoy anyone, so should I list them in a follow
> up?
Sure, go ahead. We don't annoy easily ...
Regards
Tom
--
Users can unsubscribe from the list by sending email to
emelfm2-request@xxxxxxxxxxxxx with 'unsubscribe' in the subject field or by
logging into the web interface.
Other related posts: