Re: SMP bug?

On Sat, 26 Aug 2006 22:14:59 -0500
David Jensen <djensen@xxxxxxxxxxxxx> wrote:

> I assume it's just me, or others would have reported.  I have an old 
> clunker dual PIII.
> With the last few releases, after deleting or creating a directory, I 
> often cannot enter a directory in that pane, without refreshing or 
> clicking the other pane and back.  The problem is worst with Inotify=1, 
> bad with just polling, and 'oddly' rare with gamin=1.
> I get a pop-up asking what would I like to do with <the directory 
> name>.  Hey, don't click the open button!
I have two fixes for this one.

Testers have reported success for one fix, that's scrambled into a moderately 
substantial re-write of item-opening code (to better handle items in a 
recognised filetype but with inappropriate X permission flag set). I don't 
propose to release that now.

But a small patch for 0.2.0, which should achieve the same effect, is as 
follows:

--- e2_task_backend.c   2006-08-22 21:59:57.000000000 -0400
+++ e2_task_backend-new.c       2006-08-30 08:23:06.000000000 -0400
@@ -1393,4 +1393,11 @@
        gboolean retval;
        gchar *utf, *ext, *freeme, *base = NULL;
+       gboolean addedpath = !g_path_is_absolute (path);
+       if (addedpath)
+       {
+               freeme = F_FILENAME_TO_LOCALE (curr_view->dir);
+               path = e2_utils_strcat (freeme, path);
+               F_FREE (freeme);
+       }
        utf = F_FILENAME_FROM_LOCALE (path);    //not DISPLAY
        if (e2_fs_is_dir3 (path))
@@ -1496,4 +1503,6 @@
        }
 
+       if (addedpath)
+               g_free (path);
        F_FREE (utf);
 #ifndef E2_ASYNC

You should probably also change the default filetype action for executable 
items from "./%f" to just "%f" (no quotes in either case) as the patch prepends 
an absolute path to each item to be activated.

Regards
Tom


-- 
Users can unsubscribe from the list by sending email to 
emelfm2-request@xxxxxxxxxxxxx with 'unsubscribe' in the subject field or by 
logging into the web interface.

Other related posts: