Hi, I tested the code on F4 Discovery board and also successfully blinked the leds. -Lari On 19.08.2014 07:52, Pekka Nikander wrote: > Thanks Ivan! > > I reviewed the code, overall this looks pretty good to me. > > Anyone, please provide me with an independent test report of > running this on an STM32F4discovery board, and I'll merge to > master. (I don't have any reason to believe it doesn't run, but > just from the QA point of view I'd like first to see an independent > test report.) > > A few enhancement issues could be created as github issues if > anyone cares: > > - Add support for core coupled memory > > - In the emulator, the register initialisation values should be > opened, i.e. not to be hex but the individual bits shown as > symbols - this applies also to the older code > > - Attempt to fix the FLASH_BASE issue in a more robust way (than > letting it be defined) > > - Testing if the following ASM statement can be removed in either > or both -051 and -407: __asm__ volatile ("mov sp, %0" : : "r" > (stack)); > > --Pekka > > On 2014–08–18, at 22:06 , Ivan Raul <supra.material@xxxxxxxxx> > wrote: > >> Dear All, >> >> I have created a pull request for the initial compilation of the >> stm32f4discover board on the emulator. >> >> However, it needs additional checking. >> >> From the hardware side, I tested and successfully run a blinky on >> the board with the new startup code. >> >> BTW, Today I got full permission to work on this project without >> any conflicts regarding competition, copyright, etc. >> >> Have a very nice evening >> >> >> BR, Ivan >> >> With Warm Regards, Ivan Raul >> >> >> On Fri, Aug 15, 2014 at 4:20 PM, Pekka Nikander >> <pekka.nikander@xxxxxx> wrote: >>> Jess exactly like that in Ubuntu also! >>> >>> Inputting just plain make functions OK and make clean is also >>> OK, the residue thats left is: ... -rwxrwxr-x 1 eero eero >>> 395139 Aug 15 16:01 libsketch.so >> >> Ok, thanks! >> >> I pushed this to master. >> >> I'd appreciate if you Eero (or someone) opened tickets for the >> remaining libsketch.so (or better yet add a clean:: rule in >> app.mk to remove it and make a pull request), and another ticket >> for rewriting the stm32f4discovery startup code into C. >> >> The next step now is to get the rest of Asif's changes to the >> emulator so that we can actually start running the RF test cases >> against the master branch. We penciled down Wed 27th for >> continuing this work with Asif (as I won't have time before >> that), but it would be good if someone else managed to push the >> ball forward already before that. That is, as the next step >> Asif's changes need review, and they need to be rebased on the >> top of the new master. >> >> --Pekka >> >> >> > > -- Lari Lehtomäki lari at lehtomaki dot fi 050 320 7920