[ell-i-developers] Re: PWM working for TIM2

  • From: Ivan Raul <supra.material@xxxxxxxxx>
  • To: ell-i-developers@xxxxxxxxxxxxx
  • Date: Mon, 27 Jan 2014 22:12:11 +0200

Ready, you can see the changes now.

https://github.com/supramaterial/Runtime/commit/c8dba3605bd990f5368be3726a08211a9bd4aec0#diff-6842398ca2000c00cc73ad9e6e17c7d8L60

With Warm Regards, Ivan Raul


On Mon, Jan 27, 2014 at 9:21 PM, Pekka Nikander <pekka.nikander@xxxxxx>wrote:

> > Finally the PWM ouptput for the TIM2 is working. The main problem was
> that TIM2 is a timer with some 32bit registers.
>
> Excellent!
>
> > Generates this particular assembly:
> >
> >  80002a2:    8022          strh    r2, [r4, #0]
> >
> > That slightly changes the assembly, the most important part is this:
> >
> > 80002a2:    6022          str    r2, [r4, #0]
>
> Good finding!
>
> > I am not sure if the c code is the correct one, as I know that typecast
> is not advisable.
>
> No, it is not, let's work together a better solution.  And let's consider
> the other things in your mail only later.
>
> > BWT, now I understand a little why the STM library takes so much space,
> seeing the assembly opened my eyes :)
>
> :-)
>
> > What would be the next step??
>
> Clean up your change, commit it, and push it to github.  You may want to
> push it to some temp branch, but YMMV.  You can also create a pull request
> already, if you want to.  If you want to commit it to a temp branch, the
> easiest way is something like
>
>   git push origin master:temp-branch-name
>
> e.g.
>
>   git push origin master:tentative-fix-16bit-init
>
> Anyway, please point me to the right file in github, either via a pull
> request or a with direct link to the right *line*.  (Note that you can copy
> a link to a particular line by clicking the line number and then copying
> the link from the URL box.)
>
> I really need to see the whole code in order to think about how to get it
> right, just a few lines of code out of the context is not enough.  More
> generally, I think it is better to commit a temp branch to github and point
> to it, rather than copy & paste code to e-mail.  You can then leave the
> temp branches there in github, if you wish, they don't harm anybody but
> document the history.
>
> --Pekka
>
>
>

Other related posts: