[ell-i-developers] Re: Ellduino Emulator: Fixing issues for Linux (Ubuntu 12.04 LTS)
- From: Pekka Nikander <pekka.nikander@xxxxxx>
- To: ell-i-developers@xxxxxxxxxxxxx
- Date: Fri, 14 Feb 2014 08:56:57 +0200
> ../emulator/inc/stm32f0xx.h:61:19: fatal error: USART.H: No such file or
> directory
That is a simple typo in stm32f0xx.h. It should be USART.h of course. I'm
running Mac OS X with a case-insensitive file system, so it didn't bite me.
Please fix it and create a pull request. That is, this is now a very good
occasion to learn how to create Github pull requests. And maybe also document
it briefly in our wiki. Here is the main article in github:
https://help.github.com/articles/using-pull-requests
We are currently using fork & pull method, as I still want to be the gatekeeper
to the source code, making sure that our code quality stays high. We will
gradually relax that, granting people direct push rights, but only gradually...
So, the idea is that you fork the repo, fix the bug, commit the fix, push the
commit into your forked repo into a temporary branch (e.g.
bug-fix-header-typo), and create a pull request. If you have any difficulty,
Ivan has recently learned how to do that. It would be good to document the
difficulties into a Wiki page.
> I found follwing lines in ....../Runtime/stm32/stm32/emulator/inc/stm32f0xx.h
> /*
> * Undefine the main address defines in the real stm32f0xx.h, causing
> * a compile error on all constructs that use them.
> */
>
> Can you please elaborate on it more ...
That comment refers to the three following lines:
#undef FLASH_BASE
#undef SRAM_BASE
#undef PERIPH_BASE
Those three preprosessor macros are defined in the
system/stm32/inc/stm32f0xx.h, as RCC, FLASH, GPIO, etc. However, while RCC,
FLASH, GPIO etc are real peripheral addresses, FLASH_BASE, SRAM_BASE and
PERIPH_BASE are "main address defines" (bad choice of words -- please consider
fixing). Please see the system/.../stm32f0xx.h to understand better.
--Pekka
Other related posts:
