[dokuwiki] Re: upgradeplugindirectory plugin


On 23 Jan 2009, at 08:49, Anika Henke wrote:


Christopher Smith wrote:
Mon Jan 19 04:01:43 WST 2009 Chris Smith <chris.eureka@xxxxxxxxxxxxx> 
 * Major rework of pluginutils
Finally, this patch contains a one-shot action plugin which will automatically convert a plugins directory from the old style disabled file to the new style.
I was just wondering if this plugin is really needed. Couldn't we just tell the wiki admins that the disabled plugins won't be disabled anymore and they have to go to the plugin manager in order to disable them again? Disabling plugins is not such a big matter as importing the old changelog or the old index was ... (Doing it on your own will take you 2 minutes, if at all, whereas no- one would have been able to manually import the changelog from the old to the new format.)
Possibly, but the consequences of not doing it are potentially more serious than not importing the old change log or the old index. E.g. If you have disabled plugins due to security vulnerabilities, those plugins could become enabled.
Also the problem below will occur in the same manner if the disabling is done manually. Its not a function of the plugin but the disabling mechanism. And it will continue to recur when ever a new one-shot plugin is used.
Note for darcs users, the new disabled format will mean a couple of old oneshot plugins, importoldchangelog and importoldindex, will have their directory names 
 changed, which could lead to darcs wanting to record the change.
This is really annoying. Does this mean that we (darcs users) will be asked if we want to record this for the next 200 years every time we need to record something else? Is there any way around this? (I don't know much about darcs, maybe there is on option for that?)
For your own wiki, use "darcs record" to record the change. If you send patches through to Andi, never send this one. I include something in the patch title to remind myself its not for sending (e.g. 'DO NOT SEND'). When this happens to new (yet to be released) one-shot plugins, use "darcs amend-record" to update that original patch and keep the number of patches dealing with this small.
This was an unintended consequence of the change. Andi did some profiling of DokuWiki and one of the things it highlighted was the number of file accesses to setup the plugins. Including "disabled" in the directory name would automatically halve that number -- it would no longer be necessary to do a second read to look for the plugin/ disabled file. The actual problem was worse than that as DokuWiki could end up scanning for plugins several times. This change keeps that scan to once only. 


- Chris

--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: