[dokuwiki] Re: some more things that need a look

Andreas Gohr wrote:
What about the language strings for the plugins delivered with
DokuWiki? Currently strings for the ACL manager are defined in the
global lang folder, the ones for the other management plugins come with
their own lang folders... I guess the cleaner aproach would be to fix
the ACL plugin? Or should everything coming with DokuWiki be handled in
a central place
I think its better to keep the plugin lang strings separate. It reduces the loading on Dokuwiki, why load strings that aren't necessary 99% of the time? Ideally the ACL strings should be moved. You're in charge of prioritisation, but I'd put it in the "it ain't broke" box. 
Is the refresh button in the plugin manager still needed? If I remember
correctly it was for joining CSS and JavaScript files? So it should be
obsolete now?

No its obsolete - worse redundant. I removed the code that handled the refresh a few patches back. I forgot the button. I'll remove it and send a patch asap. 
The DOMlib used by the footnote tooltips causes a bunch of warnings in
my Firefox. It is also a quite huge lib (compared with the rest of
DokuWiki's javascript) duplicating some of DokuWiki's script code. Whats
your opinion on this. Should I go and

a) reimplement the whole tooltips stuff, throwing out the DOMlib
b) just fix the warnings in the DOMlib code
c) ignore this and concentrate on the things that //need// fixing
before the next release
Odd, I get no warnings. (a), (b) or (c), I have no opinion, up to you. 
I just added a handy JavaScript behaviour to automatically scroll to an
element when it has the id scroll__here. I added it to the user manager
to let it scroll the user edit form into view. This could also be used
to scroll down to the preview in the edit view after pressing the
preview button. Question is should I add this? I would vote for yes, but
sometimes you just press preview for renewing the lock and then you
maybe don't want this behaviour...

Cool.  Add an extra button, "refresh lock"?

I noticed you added $() from prototype library. I am curious what it adds. I lurk on Dojo's mailing list and a while back someone suggested adding it to the dojo toolkit and was met with a long, considered and detailed argument as to the evils of $() - but also an admission of being a competiting toolkit and so quite possibly a different world view.

Cheers,

Chris

--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: