[dokuwiki] Re: [patch] You Are Here
- From: Andreas Gohr <andi@xxxxxxxxxxxxxx>
- To: dokuwiki@xxxxxxxxxxxxx
- Date: Wed, 14 Dec 2005 20:02:54 +0100
On Tue, 13 Dec 2005 14:40:48 -0500
Sean Coates <sean@xxxxxxxxxxx> wrote:
> http://sean.caedmon.net/patches/dokuwiki-youarehere.patch
>
> Basically, it finishes the "You Are Here" implementation that someone
> else already started. I had to add an element to the en langauge, so
> language maintainers will have to handle the other languages.
>
> I also added a new config element 'youarehere' (off by default).
>
> Let me know if I should do something differently. If not, I'd like to
> see it committed. Is this the best way?
Hi!
Your patch is fine, but I'm not sure if I should add it.
I put the youarehere function as an example how to add a hierarchical
trail. However I don't think a hierachical trail is a good thing for a
wiki as it needs strict hierarchical namespaces which works somewhat
against the wiki philosophy of "just add it". So I don't want to add
another option for it. However a patch which just updates the function
to use p_get_first_heading but leaves the default template and config
file alone I would happily add.
Andi
Other related posts:
