[dokuwiki] Re: darcs patch: parenthesis_escaper_fix

On Thu, Dec 20, 2007 at 09:55:54PM +0100, Guy Brand wrote:
> On 19 December at 10:52, stephane.chazelas@xxxxxxxxxxx wrote:
> 
> > Wed Dec 19 10:38:58 GMT 2007  stephane.chazelas@xxxxxxxxxxx
> >   * parenthesis_escaper_fix
> ...
> 
> > hunk ./inc/parser/lexer.php 578
> > -//Setup VIM: ex: et ts=4 enc=utf-8 :
> > +//Setup VIM: ex: et ts=4 sw=4 enc=utf-8 :
> 
>   This change is not related to your change and shouldn't be part of
>   your patch.
[...]

Hi Guy,

please feel free to take it away, I agree it wasn't the point of
my patch.

But is it really worth making another patch and/or flyspray task
for that?

The file that I modified had a shiftwidth of 4, so was last
edited either by someone who wasn't using vim or by someone who
had set sw=4 in his/her ~/.vimrc, as vim's default is 8. So it
makes sense to add "sw=4" here.

Also, strictly speaking, given that "et" and "enc" are vim
extensions, that line wouldn't work with other ex
implementations (that may also require "set"), so I think the
"ex:" above should be changed to "vim:".

// Setup vim: ts=4 sw=4 et enc=utf-8 :

Cheers,
Stephane
-- 
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: