[dokuwiki] Re: darcs patch: Fix wrong umask usage and so we set the ... (and 2 more)

On Fri, 24 Feb 2006 22:27:39 +0100 (CET)
Troels Liebe Bentsen <tlb@xxxxxxxxxxx> wrote:

> Fri Feb 24 22:16:55 CET 2006  Troels Liebe Bentsen <tlb@xxxxxxxxxxx>
>   * Fix umask bug and do a code cleanup of chmod/mkdir usage so set
>   the correct permissions, this should also fix problems with dokuwiki
>   making setuid files on some umasks.
>     * Don't set the umask() anymore, this is not good form and we
>     don't really know what is it in the old code anyway as it was not
>     done properly. * Retire the dmask config option introduce 2 new
>     ones called fmode and dmode, this is more in line with posix and
>     should make more sense. * Use chmod for setting the correct
>     permissions but only if it's needed. * Set changing of permissions
>     off by default as i should work properly in most Apache setups
>     without and it does not make sense on windows anyway.

I just applied your patch but have some questions.

By default none of the umask, fmode and dmode are set - resulting in
0666 for files and 0777 for directories, correct?

When the umask is set, it is combined with the values for fmode and
dmode (or the defaults above) resulting in the params fmask and dmask.
Both of them are not masks (eg. inverted) but the real permissions for
dirs and files, correct?

I can leave the umask config uncommented and just set fmode and dmode to
the value I'd like to have my files and dirs, correct?

If the above is correct, we don't really need the umask config at all,
am I right?

I feel I'm missing something here but I'm not sure what.

Andi
-- 
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: