[dokuwiki] Re: config and usermanager

Andreas Gohr wrote: 
Hi Chris (and others)!

I just pushed your latest patchset including the config and user
manager... Here are some minor things that need a look...

General:
We should decide if admin plugin names should end in '...' or not
I vote for not. Mostly I followed the ACL plugin which has '...'. I think only User Manager, Searchindex Manager & Darcs don't have ellipsis. 
Config-Manager:

The choices for GD Lib Version should be:
autodetect
Version 1.x
GD Lib not available
Fixed (sort of). This seems an odd set of options and the description in wiki:config isn't clear. What version are we trying to detect with autodetect, 1.x or 2.x?

Config can attempt to determine if GD lib is available or not, should it? Would that make GD Lib not available, "Do not use GD Lib" if GD lib was detected?
Is the plugin manager option still needed? If not it should be removed
from the config.
I have removed it and the deprecated function in pluginutils, print_jscss()
allowdebug seems to be unknown for the manager
its not on wiki:config, means I don't know about it, means the plugin didn't know about it. ;-)
I've added it based on conf/dokuwiki.php notes
Is it possible to make the authentication backend a dropdown depending
on available files in inc/auth ?
Fixed. I don't know why I didn't do that from the beginning. It was easier than what I had in place!
The dropdown in page name word seperator doesn't make too much sense.
Either make it a textfield or restrict it to . _ -
Fixed in second patch, I guess I got carried away.
'use rel no follow' should be 'use rel="nofollow"'
Changed. 
User-Manager:

Should check if the auth backend is able to handle User-Management at
all. Currently it dies with "Call to undefined function:
getusercount()" in the LDAP backend
It should, thats a bug, probably a bad designer assumption. :-)
How should a auth plugin manifest that it doesn't support user management?
For now, I've implemented a check for canDo('retrieveUsers') and it should no longer fail if getUserCount isn't provided.
The Delete Button should use a onclick and onkeypress handler calling
confirm($lang['reallydel'])
Can you do this? I expect it'll be faster for you, I'd need to investigate how it all works to keep the js out of the html.

Okay these are the things I found after quick look. Chris could you just
quick say which point you want to do - I'll do the rest. BTW: fantastic
work! Both plugins are really good looking and are a fine enhancement
for DokuWiki.
Thanks :)
User manager kudos also needs to go to neolao (who made the orig. plugin) and Matthias Grimm for all his suggestions and additions.

Patches sent.

Does anyone know how to mark darcs patches so they don't show up as options to send?
I have about five and it would be handy if they sat out the darcs send process.

Chris
--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: