[dokuwiki] Re: Toolbar missing after update

While I haven't been able to trigger the bug at will, it has occurred
once more, this time with Mozilla on Windows. I had loaded a copy of
DokuWiki that hasn't been patched for a few weeks. Viewed a page,
logged-in, edited the page, saved, then got a javascript error. This is
without applying any recent patches. Since I applied the patches, I
haven't been able to trigger it again.

It really does seem like a browser bug. And I doubt there is anything DW
can do about it. The errors come from randomly blocks of data at the end
of the normal stream. There's no guards against that. I thought putting
a /* at the end might ignore anything that gets added, but Mozilla just
complains about an unterminated comment then. And there isn't anything
that could be enclosed in an error handler. The bad stuff happens after
DW is finished generating code. It's usually a parse error, so the code
never even gets a chance to execute.

On Sun, 19 Nov 2006 00:45:38 +0000, "Chris Smith" <chris@xxxxxxxxxxxxx>
said:
> This sounds like it could be browser caching issue, especially since 
> shift+reload corrected it.  The html has changed - possibly altering the 
> DOM and causing errors in the cached javascript.  It could well be that 
> those errors are causing the js to abort before it has done its toolbar 
> magic.  It may well be the JS needs to be more segmented with 
> try/catch/finally to ensure if there is a failure in one part of the 
> onload js it doesn't impact on other unconnected parts.
> 
> Chris
> 
-- tom
telliamed@xxxxxxxxxxx

-- 
http://www.fastmail.fm - Choose from over 50 domains or use your own

-- 
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: