[dokuwiki] Re: Recent changes & import update


On Oct 27, 2006, at 2:56 AM, Anika Henke wrote:

Ben Coburn wrote:
On Oct 23, 2006, at 3:01 PM, Guy Brand wrote: 
On 23 October at 11:30, Ben Coburn wrote:

I'll look into changing the code for importing the old changelog so
that it puts all the old changes into the recent changes cache. The
changelog trimmer (in the indexer) will then cut the recent changes
cache down to size on the first run. This will also give people a whole
24 hours to set $conf['recent_days'] to the "right" value for their
wiki.


Hmmm, seems I forgot the action of the trimmer which will shrink the
cache anyway. I don't think having 24 hours to change recent_days is
a user (or admin) friendly solution. So here is an other scenario to
keep at least 20 (or whatever $conf['recent'] value is set to)
entries after importing the changes.

I think you are misunderstanding. The trimmer *already* keeps $conf['recent'] changes in the recent changes cache. This minimum number of changes will be kept no mater what value is given to $conf['recent_days']. 

Hmm ... Are you saying that with
$conf['recent'] = 20;
$conf['recent_days'] = 7;
and having only 5 pages changed during the last 7 days,
that ?do=recent should *still* be displaying 20 items??

If that is what you meant, then obviously that is not the case ...!?


Sorry to confuse you. When I talk about trimming the recent changes cache I am always talking about the number or *lines* in this file "./data/meta/_dokuwiki.changes".

In your example, there will be 20 lines in the file (unless it has *never* been that large).

There is also a big difference between the number of changelog *lines* and what "Recent Changes" (in the web) displays. The functions that generate "Recent Changes" (inc/changelog.php#getRecents and inc/changelog.php#_handleRecent) collapse multiple changes to the same page (showing only the most recent change). So, the number of "Recent Changes" displayed will only equal the number of lines in the changelog cache if each line is for a different file.

In short, "Recent Changes" will always show something.... but exactly what will depend on the data involved. (Note: "Recent Changes" was collapsing multiple changes to the same page before I rewrote the changelog system.)

Regards, Ben Coburn


-------------------
  silicodon.net
-------------------

--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: