[dokuwiki] Re: Recent changes broken

  • From: Guy Brand <gb@xxxxxxxxxxxxxxxxx>
  • To: dokuwiki@xxxxxxxxxxxxx
  • Date: Wed, 11 Oct 2006 10:06:24 +0200

On 11 octobre at 08:22, Guy Brand wrote:

>   It a bug in my installation, but maybe do=check could test this and
>   report an error:
> 
> --- infoutils.php     Tue Sep 26 00:00:02 2006
> +++ infoutils.php     Wed Oct 08 18:20:07 2006
> @@ -112,6 +112,12 @@
>      }
>    }
>  
> +  if(is_writable(DOKU_PLUGIN)){
> +    msg('Plugin dir is writable',1);
> +  }else{
> +    msg('Plugin dir is not writable: some plugins could fail.',-1);
> +  }
> +
>    if(is_writable($conf['datadir'])){
>      msg('Datadir is writable',1);
>    }else{
> 

  And more specifically for the importoldchangelog plugin, something
  like:


--- infoutils.php       Tue Sep 26 00:00:02 2006
+++ infoutils.php       Wed Oct 11 09:59:11 2006
@@ -108,6 +108,10 @@
   } else if (@file_exists($conf['changelog'].'_import_ok')) {
     msg('Old changelog imported.', 1);
     if (!plugin_isdisabled('importoldchangelog')) {
+      if(!is_writable(DOKU_PLUGIN.'importoldchangelog')){
+        msg('Importoldchangelog plugin dir not writable.', -1);
+      }
+         msg(plugin_disable('importchangelog'));
       msg('Importoldchangelog plugin not disabled after import.', -1);
     }
   }

  will do the trick.

  Fixing plugin_disable would certainly be better: it tries to touch a
  DOKU_PLUGIN/pluginame/disabled file but if an error occurs (such as
  directory not writable) does not show it through msg().

-- 
  bug

-- 
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: