[dokuwiki] Re: Proposal for an AUTH_USERDATA_CHANGE event

> > An alternative to this would be changing the auth class system from
> > inheritance to composition: The current auth class API 
> > remains, but there is one auth class that dispatches the api call 
> > to various auth adapters. While I am certainly able to do such a 
> > change, I won't do it without having the OK from the community.
> 
> Couldn't we combine this? We change our code to call
> $auth->triggerUserMod($type,...) which is a method of auth_basic and
> would wrap around $this->createUser and so on...

I am not sure if I understand you. Do you mean (for example) calling
$auth->triggerUserMod('modify', $user, $changes) in usermanager and
auth_updateprofile instead of calling $auth->modifyUser($user, $changes)?
I wanted my change to affect only the auth system and no code that uses it.
But if this approach is ok, I will gladly change the code.

Or do you mean calling $auth->triggerUserMod('modify', $olddata, $newdata)
from  $auth->modifyUser of each class? This solution IMO has no advantages
over directly initializing the event object as I did in my patch.

Greetings,

Gabriel

-- 
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: