[dokuwiki] Re: Patch: give people option to display homepage on diffs, etc...

On Mon 7 May 2012 11:09, Andreas Gohr pondered:
> > Does this make sense to anyone else?
> >
> > @@ -1416,6 +1416,7 @@ function editorinfo($username){
> > +            case 'home':
> > +                if(isset($conf['showuser']['home']))
> > +                    return '<a
> > href="'.$conf['showuser']['home'].$username.'/">'.hsc($username).'</a>';
>
> In general, yes. See FS#2151 and FS#1558

OK - I like that as well - it makes sense to me to use the interwiki link 
[[user>@USER@]].

// interwikilink($match, $name = NULL, $wikiName, $wikiUri)
   interwikilink(NULL,   $ret        ,    'user',    $username)

should work or is there a better way? (assume $ret is the username or real 
name if the interwiki link exists).

I can update tpl_userinfo() to do the same if you think that's helpful too.

> I see some problems with your patch though:
>
>   - $username needs to be escaped
>   - the link should be build through wl() (that would take care of the
> above, too)

OK - no problem.

>   - there is no way to link to a user namespace instead of a single page

Wouldn't the interwiki link handle that?

> Andi
>
> --
> splitbrain.org

--
DokuWiki mailing list - more info at
http://www.dokuwiki.org/mailinglist

Other related posts: