[dokuwiki] Re: Patch: Implicit ~~NOCACHE~~ on files with <php>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all!

I've finally gotten around to implementing the syntax plugin and trying
out the patch against the latest darcs and all looks well.  Both are
located at:

http://schmong.org/dokuwiki

The plugin can also be directly installed from:

http://schmong.org/dokuwiki/phpimplicitnocache.zip

(and I stuck an entry in the plugin repo, too :-) )

Does anyone have any remaining objections to the "Assume NOCACHE on
pages containing PHP code" config option?

The patch adds a config option to core DW that can be turned off/on.
The plugin just silently does it (I assume that, if someone
installs/enables the plugin, they know what they're doing :-) ).

- --bj

B.J. Black wrote:
> Hello!
> 
> Here's a fresh patch with the change below and Jean Marc's French i18n.
>  The syntax plugin is a bit trickier, though, since I don't want to
> actually consume the <php>...</php> block (just make a note that it's
> there and pass-through to the next handler).  I'll ask about that
> problem in a separate email.
> 
> --bj
> 
> Chris Smith wrote:
>> Hi,
> 
>> For ease of upgrading, you may be better to implement this as a syntax
>> plugin.  Use the same patterns as used by the parser with a lower sort
>> number.  The lower sort number ensures your plugin gets the code rather
>> than DW.
> 
>> I also think a better implementation is to set the renderer property
>> "info['cache']" to false rather than to use the handler to generate two
>> instructions for the "php" mode.  e.g. for the patch,
>> inc/parser/xhtml.php @308, insert  your test + $this->info['cache'] =
>> false, or in a syntax plugin, in the renderer method, add your test +
>> $renderer->info['cache'] = false;
> 
>> -- Chris
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHS9QhBWZe+3ib/AERAubPAJ9eL9+Y1ydO1g6F+6CptdbqzjtydwCZAblV
yT3eIQSuX50HnBZNZF1TgWk=
=1OGT
-----END PGP SIGNATURE-----
-- 
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: