[dokuwiki] Re: [Patch] - Hide "old revs" when not actin show

Michael Klier wrote:

> I don't think that's a good idea for a couple of reasons:

> As a template developer I'd expect that both, tpl_button() and
> tpl_actionlink() work exactly the same for all button types and I think
> it's out of the scope of both functions to handle the logic whether a  button should
> be shown or not

But there are already logic hiding button and links depening on your login status and permissions.

> Your argument about the context is debatable, because you don't know if other
> templates provide additional context. In case of the default template I would
> argue that you always see the current page name/title in the upper left
> corner, just above the revisions button. For people who know that the button
> does this might be just the context they need.

Yes, this is true, but how often will you personally miss the shortcut from do=edit to do=revisions?

> Also I think the example with the novice admin is a little far fetched,
> clicking on the link once should be enough for most people to realize that reverting
> to an older config is not what it does ;-).

Well, IMHO first impressions last. It is the noob admin that gives 3-5 different wikis a try
then choosing the one that felt best (given that he has done his homework at www.wikimatrix.org). Every single click should do what he/she wants and expect.

> And as you said already, the patch is a tad bit invasive in that it will affect
> all templates, which I think is not optimal either.

Yes, naturally I want to spread the good behavior regardless of used template ;-). Actually I'm more
interested in a discussion about usability, which I think is good in DokuWiki. But there's always
room for improvements, like tuning the first time impression and reviewing FAQ/forums for common errors
and making design solutions (people never read documentation). The "old revs" button is just a very
concrete case.

More opinions please.

Regards,

/Håkan