[dokuwiki] Re: [PATCH] MySQL canDo() patch

On Mon, 30 Jan 2006 22:07:56 +0000
Chris Smith <chris@xxxxxxxxxxxxx> wrote:

> > The Profile button needs delGroup and delUserGroup configs? Probably
> > because it's checked with modifyUser? Chris? Any ideas? I don't want
> > to configure any deletion commands, but like the Profile
> > management...
>
> You've lost me.

Oh. Sorry I try again.

The profile button is only shown when $auth->canDo('modifyUser') returns
true. The MySQL backend only returns true for that when the delGroup and
delUserGroup config strings are set.

This is bad because both are not needed for letting a user change
it's profile (You can't change your groups in the profile dialog).

But I assume (not checked) the user manager will use
$auth->canDo('modifyUser') to check if user modification is possible,
too. And of course as Admin I can change a user's group so the checks in
the MySQL module are reasonable for this case.

> Or are you refering to UserManager plugin?
> Where leaveGroup & joinGroup should be tested before enabling user
> input  in the groups field and before sending group data to
> modifyUser. I'll  work out a patch for that and forward it asap.

Maybe this already is the solution. We then could remove the delGroup
and delUserGroup requirements in the canDo check of the MySQL backend.

Andi

Other related posts: