Esther Brunner wrote:
One thing I'm not yet sure about, is whether helper plugins, that are required for another plugin, should be bundled. I think Chris mentioned once, the plugin manager could handle installing multiple plugins at once, but would it check if the installed version was newer or would it just overwrite? -- esther
Hi Esther,It took me a while to get my head around this idea, now I have, I think its really clever and very useful. :)
I think you do probably need one change in the main DW codebase - adding "helper" to the list of valid plugin types. That will get their details listed in the plugin manager.
One question:- Your method of loading the helper plugin will load it irrespective of its disabled setting. That could well be desirable, it would, for example, allow the blog plugin to work whilst preventing the include plugin syntax. Is that what you intended?
And, no the plugin manager has no version control. Its update function simply looks at the original plugin location and downloads/installs it again. It may not be that difficult to give it some sort of version functionality. At present, for both new installs and updates, the plugin manager downloads and decompresses the plugin in a temporary directory, before copying it to the actual plugin directory. After downloading/decompression it could do some version investigation and determine whether or not to overwrite an existing copy. I would guess the best solution would be to include a version file.
Andi, what do you think?I took a look at your wiki page for the new include plugin. You don't list any changes in the update. Apart from your reorganisation for the helper plugin, were there any changes?
I have been tinkering with the include plugin to allow caching of the included pages through an action plugin component handling the PARSER_CACHE_USE event. There may be some other improvements. It'd be handy to know which bits to check before offering a patch back to you.
Cheers, Chris -- DokuWiki mailing list - more info at http://wiki.splitbrain.org/wiki:mailinglist
