[dokuwiki] Re: Fwd: performance tweak in Dokuwiki Lexer


On 15 Apr 2009, at 08:31, Andreas Gohr wrote:



The code seems to work but we don't have any unit tests for that
function. Chris since you're the author of the original function,
could you have a look at Mike's code and maybe provide a unit test?




It won't work, patterns can (and do) include look aheads.

http://bugs.splitbrain.org/index.php?do=details&task_id=538
http://dev.splitbrain.org/darcsweb/darcsweb.cgi?r=dokuwiki;a=commit;h=20050916113259-9b6ab-47b502b4c7410d17229923d03c30ace76b7b1853.gz
The bug report comments contain some of the decision making behind the original change from strpos to preg_split. 

- Chris



--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: