[dokuwiki] Re: Fw: Dokuwiki patch - synchronize changelog


On Oct 26, 2006, at 2:15 PM, Andreas Gohr wrote:

One thing is that this could destroy the order in the changelog. Is
this an issue in the changelog parsing code?


This would only happen if something caused the page to have a
modification time in the past. I will update the patch so that this
kind of "bogus edit" is ignored and does not break the changelog line
order.


Okay this will work for the individual page changelogs, but not for the
global cache one, but I think we can live with this restriction?


You are right about the global changelog cache, but it is a little better than that. Thanks to the "ksort" that was added to the recent changes trimmer, any out of order lines will get resorted within 24 hours. I don't think an out of order line will cause major problems while it is out of place.

Just one more question: What happens with attic modifications by
maintenance scripts? Eg. I currently delete attic files older than 30
days. So if a page is older than 30 days and then is edited, the code
will "think" it it has to create a new changelog entry? I guess a
simple check if the changelog entry already exist will be enough to
circumvent this. Of course the attic file needs to be created in such a
a case.


I already check against the most recent changelog entry. So in this case the attic file would be recreated because it is missing (your script deleted it) but the changelog will remain unchanged.

Regards, Ben Coburn


-------------------
  silicodon.net
-------------------

--
DokuWiki mailing list - more info at
http://wiki.splitbrain.org/wiki:mailinglist

Other related posts: