[dokuwiki] Re: Fw: Dokuwiki patch - synchronize changelog

  • From: Andreas Gohr <andi@xxxxxxxxxxxxxx>
  • To: dokuwiki@xxxxxxxxxxxxx
  • Date: Thu, 26 Oct 2006 23:15:54 +0200

Hi Ben!

Sorry for the long silence, I was quite busy.

> > One thing is that this could destroy the order in the changelog. Is
> > this an issue in the changelog parsing code?
> This would only happen if something caused the page to have a 
> modification time in the past. I will update the patch so that this 
> kind of "bogus edit" is ignored and does not break the changelog line 
> order.

Okay this will work for the individual page changelogs, but not for the
global cache one, but I think we can live with this restriction?

Just one more question: What happens with attic modifications by
maintenance scripts? Eg. I currently delete attic files older than 30
days. So if a page is older than 30 days and then is edited, the code
will "think" it it has to create a new changelog entry? I guess a
simple check if the changelog entry already exist will be enough to
circumvent this. Of course the attic file needs to be created in such a
a case.

> > As you say your self this means usually each page is stored twice,
> > once in pages and once in attic. Should we maybe store a 0-byte
> > version in the attic instead?
> No. The whole point is that when a page is edited outside dokuwiki
> the current revision and page data are already correctly stored in
> the attic. This is what the second save to the attic is for.

You're right of course, that was a stupid idea (didn't thought this



Other related posts: